Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong integer conversion when computing xpmax in norver function #281

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Sep 13, 2024

As mesh->xpmax, mesh->xp and mesh->npmax are MMG5_int (since the adding of int64_t integers support), we have to cast the double value computed into a MMG5_int value and not a long long one.

@Algiane Algiane added kind: cleanup should be clean part: mmg3d mmg3d specific labels Sep 13, 2024
@Algiane Algiane self-assigned this Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.44%. Comparing base (88d9d1e) to head (53b5af3).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #281   +/-   ##
========================================
  Coverage    50.44%   50.44%           
========================================
  Files          177      177           
  Lines        47236    47236           
  Branches     10276    10276           
========================================
  Hits         23830    23830           
  Misses       15674    15674           
  Partials      7732     7732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coprigent coprigent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@coprigent coprigent merged commit ad10412 into develop Sep 14, 2024
49 checks passed
@coprigent coprigent deleted the feature/fix-integer-conversion branch September 14, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup should be clean part: mmg3d mmg3d specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants