Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix build gettagname #282

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Sep 14, 2024

Fix missing VTK header (vtkSmartPointer.h) when compiling the mmg_get_tagname unit test with USE_ELAS set to OFF and USE_VTK to ON.

@Algiane Algiane changed the base branch from master to develop September 14, 2024 20:12
@Algiane Algiane self-assigned this Sep 14, 2024
@Algiane Algiane added kind: bug error or fault part: cmake cmake part labels Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.44%. Comparing base (ad10412) to head (f0d2722).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #282   +/-   ##
========================================
  Coverage    50.44%   50.44%           
========================================
  Files          177      177           
  Lines        47236    47236           
  Branches     10276    10276           
========================================
  Hits         23830    23830           
  Misses       15674    15674           
  Partials      7732     7732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coprigent coprigent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@coprigent coprigent merged commit f6b3408 into develop Sep 19, 2024
49 checks passed
@coprigent coprigent deleted the feature/fix-build-gettagname branch September 19, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug error or fault part: cmake cmake part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants