fix: PR comments

MobilityData · Feb 16, 2024 · 9e56507 · 9e56507
1 parent 04c0938
commit 9e56507
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/...src/main/java/org/mobilitydata/gtfsvalidator/validator/NetworkIdConsistencyValidator.java b/...src/main/java/org/mobilitydata/gtfsvalidator/validator/NetworkIdConsistencyValidator.java
@@ -32,15 +32,17 @@ public void validate(NoticeContainer noticeContainer) {
     // Validate the presence of network_id in routes and its specification in either route_network
     // or network files
     boolean hasNetworkIdField = this.routeTableContainer.hasColumn(GtfsRoute.NETWORK_ID_FIELD_NAME);
-    if (hasNetworkIdField && !this.routeNetworkTableContainer.isMissingFile()) {
-      noticeContainer.addValidationNotice(
-          new RouteNetworksSpecifiedInMoreThanOneFileNotice(
-              GtfsRoute.FILENAME, GtfsRouteNetwork.FILENAME));
-    }
-    if (!this.networkTableContainer.isMissingFile() && hasNetworkIdField) {
-      noticeContainer.addValidationNotice(
-          new RouteNetworksSpecifiedInMoreThanOneFileNotice(
-              GtfsRoute.FILENAME, GtfsNetwork.FILENAME));
+    if (hasNetworkIdField) {
+      if (!this.routeNetworkTableContainer.isMissingFile()) {
+        noticeContainer.addValidationNotice(
+            new RouteNetworksSpecifiedInMoreThanOneFileNotice(
+                GtfsRoute.FILENAME, GtfsRouteNetwork.FILENAME));
+      }
+      if (!this.networkTableContainer.isMissingFile()) {
+        noticeContainer.addValidationNotice(
+            new RouteNetworksSpecifiedInMoreThanOneFileNotice(
+                GtfsRoute.FILENAME, GtfsNetwork.FILENAME));
+      }
     }
 
     // Validate the uniqueness of route_id and network_id association