Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify stops.txt to be conditionally required #1797

Closed
mobilitydataio opened this issue Aug 8, 2024 · 4 comments · Fixed by #1868
Closed

Modify stops.txt to be conditionally required #1797

mobilitydataio opened this issue Aug 8, 2024 · 4 comments · Fixed by #1868
Assignees
@cka-y
Labels
flex Rules and rule changes related to GTFS-Flex.
Milestone
6.0 Validator Rel...

Comments

@mobilitydataio
Copy link

Commit Nº 1

AUTHOR × DATE

  • Tzu-Jen Chan ( tzujenchanmbd )
  • August 7, 2024 @ 03:56 PM ETC (07:56 PM UTC)

MESSAGE

Change stops.txt presence because of demand responsive services  (#472)
* Change stops.txt presence because of DRT
* change condition wording for stops.txt

FILES CHANGED

google/transit@4080084

https://github.com/google/transit/commit/40800847529786577e5dae9382ff73764986eb16
@mobilitydataio mobilitydataio added the status: Needs triage Applied to all new issues label Aug 8, 2024
@emmambd emmambd changed the title 2024-08-08 — 1 new commit(s) made to reference.md in Google Transit's repo Modify stops.txt to be conditionally required Aug 19, 2024
@emmambd emmambd added this to the 6.0 Validator Release milestone Aug 19, 2024
@jcpitre jcpitre mentioned this issue Sep 3, 2024
Closed
@emmambd emmambd removed their assignment Sep 5, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label Sep 9, 2024
@emmambd
Copy link
Contributor

emmambd commented Sep 9, 2024 •
edited by cka-y
Loading

Tasks:

  • Modify stops.txt annotation: from Required to Conditionally Required
  • Add missing_required_file rule which should be generated in cases where there is no stops.txt AND locations.geojson.

@emmambd emmambd added status: Ready An issue that is ready to be worked on. status: Blocked Can't work on it currently because of an external factor. and removed status: Needs triage Applied to all new issues labels Sep 9, 2024
@emmambd emmambd removed the status: Ready An issue that is ready to be worked on. label Sep 16, 2024
@emmambd
Copy link
Contributor

emmambd commented Oct 1, 2024

Unblocked once #1750 is merged

@cka-y cka-y self-assigned this Oct 2, 2024
@cka-y cka-y removed the status: Blocked Can't work on it currently because of an external factor. label Oct 2, 2024
@tzujenchanmbd
Copy link

Clarification on missing_stops_file rule:
The notice should be generated in cases where there is no stops.txt and locations.geojson. Not related to location_groups.txt.

@cka-y
Copy link
Contributor

cka-y commented Oct 3, 2024

thanks @tzujenchanmbd for the clarification -- i updated the tasking to reflect that!

@cka-y cka-y linked a pull request Oct 3, 2024 that will close this issue
feat: modify stops.txt to be conditionally required #1868
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cka-y cka-y

Labels
flex Rules and rule changes related to GTFS-Flex.
Projects
None yet
Milestone
6.0 Validator Release
Development

Successfully merging a pull request may close this issue.

feat: modify stops.txt to be conditionally required MobilityData/gtfs-validator
4 participants
@cka-y @emmambd @mobilitydataio @tzujenchanmbd