Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify stops.txt to be conditionally required #1868

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Oct 3, 2024

Summary:

Modifies stops.txt to be conditionally required.
Logic: If stops.txt doesn't exist, only trigger a missing_required_file notice if locations.geojson also doesn't exist.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y linked an issue Oct 3, 2024 that may be closed by this pull request
@MobilityData MobilityData deleted a comment from github-actions bot Oct 3, 2024
@MobilityData MobilityData deleted a comment from github-actions bot Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 25b0c72
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.03 4.07 ⬆️+0.03
Median -- 1.42 1.48 ⬆️+0.06
Standard Deviation -- 11.24 11.28 ⬆️+0.03
Minimum in References Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.51 0.66 ⬆️+0.16
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 285.87 288.37 ⬆️+2.50
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.53 0.55 ⬆️+0.01
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 285.87 288.37 ⬆️+2.50

Copy link
Contributor

github-actions bot commented Oct 3, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 238cdd7
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.03 4.07 ⬆️+0.04
Median -- 1.43 1.47 ⬆️+0.04
Standard Deviation -- 11.46 11.45 ⬇️-0.01
Minimum in References Reports us-california-flex-v2-developer-test-feed-2-gtfs-1818 0.51 0.55 ⬆️+0.05
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 296.41 297.26 ⬆️+0.85
Minimum in Latest Reports us-oregon-hut-airport-shuttle-gtfs-635 0.68 0.52 ⬇️-0.16
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 296.41 297.26 ⬆️+0.85

Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit 2a02346 into master Oct 7, 2024
335 checks passed
@cka-y cka-y deleted the feat/1797 branch October 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify stops.txt to be conditionally required
3 participants