Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decreasing_or_equal_stop_time_distance includes prevShapeDistTraveled #1631

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix: decreasing_or_equal_stop_time_distance includes prevShapeDistTraveled #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce6d10f
fix: decreasing_or_equal_stop_time_distance includes prevShapeDistTra…
cka-y Jan 4, 2024
d0e8673
fix: test and formatting
cka-y Jan 4, 2024
2fb541f
Merge branch 'master' into feat/1556
cka-y Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...in/java/org/mobilitydata/gtfsvalidator/validator/StopTimeIncreasingDistanceValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static class DecreasingOrEqualStopTimeDistanceNotice extends ValidationNotice {
* Actual distance traveled along the shape from the first shape point to the previous stop
* time.
*/
private final double prevStopTimeDistTraveled;
private final double prevShapeDistTraveled;

/** The previous record's `stop_times.stop_sequence`. */
private final int prevStopSequence;
Expand All @@ -113,15 +113,15 @@ static class DecreasingOrEqualStopTimeDistanceNotice extends ValidationNotice {
double shapeDistTraveled,
int stopSequence,
long prevCsvRowNumber,
double prevStopTimeDistTraveled,
double prevShapeDistTraveled,
int prevStopSequence) {
this.tripId = tripId;
this.stopId = stopId;
this.csvRowNumber = csvRowNumber;
this.shapeDistTraveled = shapeDistTraveled;
this.stopSequence = stopSequence;
this.prevCsvRowNumber = prevCsvRowNumber;
this.prevStopTimeDistTraveled = prevStopTimeDistTraveled;
this.prevShapeDistTraveled = prevShapeDistTraveled;
this.prevStopSequence = prevStopSequence;
}
}
Expand Down
1 change: 0 additions & 1 deletion main/src/test/java/org/mobilitydata/gtfsvalidator/validator/NoticeFieldsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public void testNoticeClassFieldNames() {
"prevShapeDistTraveled",
"prevShapePtSequence",
"prevStopSequence",
"prevStopTimeDistTraveled",
"recordId",
"recordSubId",
"routeColor",
Expand Down
Loading