-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display ERRORS first on validator documentation #1667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cka-y It looks like this original order is also affecting the actual HTML report (it's warning, info, error right now). I assume this would be a different issue - is that correct? |
I included it as part of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after testing order on a few feeds
✅ Rule acceptance tests passed. |
model/src/main/java/org/mobilitydata/gtfsvalidator/notice/SeverityLevel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a question on a minor point, but could be merged as-is.
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/ReportSummary.java
Outdated
Show resolved
Hide resolved
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✅ Rule acceptance tests passed. |
Summary:
Closes #1605
Expected behavior:
ERROR
notices are displayed first, followed byWARNING
and thenINFO
in both the documentation and validation report.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything