-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: threshold of 1.11m on equal_shape_distance_diff_coordinates
#1675
Conversation
equal_shape_distance_diff_coordinates
❌ Invalid acceptance test. |
❌ Invalid acceptance test. |
I did a deep dive into the data reported during our last release (4.2) and used that as the source of truth to compare the original number of feeds that triggered this error vs. the revised list from these acceptance tests. This threshold reduces the number of feeds triggered by this error by 50% (174 -> 87). If there are persistent user concerns after this rule change, we can revisit the threshold by doing analysis on all notice occurrences with the updated rule and the difference in metres for each occurrence, and then doing a distribution graph to help determine a more lenient threshold. For this release iteration, 1.11m is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cka-y 1 minor comment re: notice name
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Show resolved
Hide resolved
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Outdated
Show resolved
Hide resolved
❌ Invalid acceptance test. |
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Outdated
Show resolved
Hide resolved
❌ Invalid acceptance test. |
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Show resolved
Hide resolved
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Show resolved
Hide resolved
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/mobilitydata/gtfsvalidator/validator/ShapeIncreasingDistanceValidator.java
Outdated
Show resolved
Hide resolved
❌ Invalid acceptance test. |
❌ Invalid acceptance test. |
Summary:$1.11 m$ threshold to distinguish between $\ge 1.11m$ ) and $\lt 1.11 m$ ) levels. Given the expansion of the Mobility Database since these initial discussions, reevaluating this threshold with current data offers a chance to refine the rule's sensitivity.
Closes #1638
Closes #1678
Concerns have been raised about the
equal_shape_dist_diff_coordinates
error's sensitivity to minor coordinate discrepancies. Historical discussions proposed aERROR
(WARNING
(Expected behavior:
equal_shape_distance_diff_coordinates
, triggering anERROR
for distancesequal_shape_distance_diff_coordinates_below_threshold
, withWARNING
severity for distancesAcceptance tests results:$1.11m$ , thus qualifying for both
The acceptance tests results show a 6% reduction (93 notices) in
ERROR
notices. Additionally, 166 newWARNING
notices were generated. This is because certain datasets exhibited distances between coordinates that were both greater than and less thanWARNING
andERROR
notices.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything