Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Predefined Routes with Deviation trigger + test #1862

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Oct 1, 2024

Summary:

This PR fixes the behavior for the Predefined Routes with Deviation feature, ensuring that it is correctly displayed for GTFS Flex feeds, such as this example.

A test case has also been added to validate the fix.

Validation Screenshot

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y linked an issue Oct 1, 2024 that may be closed by this pull request
@emmambd emmambd requested a review from tzujenchanmbd October 1, 2024 19:43
@emmambd
Copy link
Contributor

emmambd commented Oct 1, 2024

@cka-y Resolved! Thank you

Copy link
Contributor

github-actions bot commented Oct 1, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 73173a6
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.07 4.13 ⬆️+0.06
Median -- 1.43 1.47 ⬆️+0.04
Standard Deviation -- 11.51 11.60 ⬆️+0.09
Minimum in References Reports us-california-flex-v2-developer-test-feed-2-gtfs-1818 0.50 0.52 ⬆️+0.02
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 290.81 291.92 ⬆️+1.12
Minimum in Latest Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.52 0.52 ⬆️+0.00
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 290.81 291.92 ⬆️+1.12

Copy link

@tzujenchanmbd tzujenchanmbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature displayed lgtm! Thanks!

Copy link
Contributor

github-actions bot commented Oct 2, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 2dfc3b6
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.08 4.12 ⬆️+0.04
Median -- 1.43 1.49 ⬆️+0.06
Standard Deviation -- 11.66 11.52 ⬇️-0.13
Minimum in References Reports us-california-city-of-wasco-gtfs-1788 0.51 0.55 ⬆️+0.04
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 304.08 293.01 ⬇️-11.07
Minimum in Latest Reports us-california-flex-v2-developer-test-feed-2-gtfs-1818 0.58 0.54 ⬇️-0.05
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 304.08 293.01 ⬇️-11.07

@cka-y cka-y merged commit f89774a into master Oct 3, 2024
284 checks passed
@cka-y cka-y deleted the feat/1859 branch October 3, 2024 19:12
Copy link
Contributor

github-actions bot commented Oct 3, 2024

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 901cc9f
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.02 4.08 ⬆️+0.06
Median -- 1.42 1.48 ⬆️+0.05
Standard Deviation -- 11.32 11.30 ⬇️-0.01
Minimum in References Reports us-california-city-of-wasco-gtfs-1788 0.52 0.53 ⬆️+0.01
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 290.01 290.69 ⬆️+0.68
Minimum in Latest Reports us-florida-citrus-county-transit-gtfs-630 0.65 0.53 ⬇️-0.13
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 290.01 290.69 ⬆️+0.68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic for Predefined Routes with Deviation is broken
4 participants