Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade missed e2e upload artifact to v4 #1937

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Jan 8, 2025

Summary:

Missed from previous #1926 work.

Out of scope
Leaving out of scope the fix of Python scripts running in ubuntu-latest. This will be solved in #1938

Expected behavior:
The upload artifact is upgraded to v4, and the E2E test passed. Successfully build link.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez changed the title upgrade upload artifact to v4 chore: upgrade missed e2e upload artifact to v4 Jan 8, 2025
This reverts commit 355d5c9.
This reverts commit be52f33.
This reverts commit 23f1b2a.
@davidgamez davidgamez marked this pull request as ready for review January 8, 2025 20:27
Copy link
Contributor

github-actions bot commented Jan 8, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 41dc2f0
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1788 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1788 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1788 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1788 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1788 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.03 4.23 ⬆️+0.19
Median -- 1.38 1.49 ⬆️+0.11
Standard Deviation -- 12.05 12.06 ⬆️+0.01
Minimum in References Reports us-california-city-of-wasco-gtfs-1788 0.52 0.63 ⬆️+0.12
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 330.33 329.14 ⬇️-1.19
Minimum in Latest Reports us-california-catalina-express-gtfs-299 0.53 0.57 ⬆️+0.04
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 330.33 329.14 ⬇️-1.19
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 477.12 MiB 488.15 MiB ⬆️+11.03 MiB
Median -- 241.19 MiB 240.50 MiB ⬇️-702.41 KiB
Standard Deviation -- 894.23 MiB 919.78 MiB ⬆️+25.55 MiB
Minimum in References Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 34.47 MiB 34.49 MiB ⬆️+20.39 KiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.55 GiB 11.38 GiB ⬇️-181.16 MiB
Minimum in Latest Reports us-california-camarillo-area-transit-gtfs-2234 34.48 MiB 34.48 MiB ⬇️-8.00 KiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.55 GiB 11.38 GiB ⬇️-181.16 MiB

@davidgamez davidgamez requested a review from jcpitre January 9, 2025 15:49
@davidgamez davidgamez merged commit e1e34ea into master Jan 9, 2025
86 checks passed
@davidgamez davidgamez deleted the chore/upgrade-upload-artifact branch January 9, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants