feat: 1814 flex forbidden continuous pickup or drop off #1941
+220
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:MobilityData/gtfs-validator into 1814-flex-forbidden_-continuous_pickup_or_drop_off
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit f0f1055 📊 Notices ComparisonNew Errors (50 out of 1792 datasets, ~3%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
Suggestion - Notice name: continuous_pickup_drop_off -> forbidden_continuous_pickup_drop_off Description: |
|
@tzujenchanmbd Please take a look and feel free to approve the PR. |
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 134191a 📊 Notices ComparisonNew Errors (50 out of 1792 datasets, ~3%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 840490e 📊 Notices ComparisonNew Errors (50 out of 1792 datasets, ~3%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1792 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1792 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
tzujenchanmbd
approved these changes
Jan 16, 2025
|
@tzujenchanmbd I find the number of feeds that trigger this error to be surprising - it's high. Is that expected from your perspective? |
|
Let me have a look before merging |
|
@emmambd thanks for catching this! Checked a couple of feeds that seems to trigger false positive error? such as: All |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1814
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything