Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump verified Version to 12 #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

baal000
Copy link
Contributor

@baal000 baal000 commented Oct 11, 2023

I verified that this Module is still working as intended without any changes to the codes so I'd say you can close #29 and #26 with this PR

Update verified Version
Increase Module Version
@CaosFR
Copy link

CaosFR commented Jul 11, 2024

Thanks for your work; the main branch lock dead.
Can you do the same for v12 ?

I found no Issues using it in Foundry Version 12
@baal000
Copy link
Contributor Author

baal000 commented Oct 15, 2024

Verified Version is bumped to 12

@baal000 baal000 changed the title Bump verified Version to 11 Bump verified Version to 12 Oct 15, 2024
@CaosFR
Copy link

CaosFR commented Oct 25, 2024

Amazing :) How I can install your fork ?

https://github.com/baal000/fvtt-chat-notifications/blob/master/module.json give me this error :

Uncaught (in promise) Error: [undefined] Cannot read properties of null (reading 'id')
at checkPackage (file:///home/foundry/resources/app/dist/packages/views.mjs:1:1179)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Module.installPackage (file:///home/foundry/resources/app/dist/packages/views.mjs:1:2011)

https://raw.githubusercontent.com/baal000/fvtt-chat-notifications/master/module.json give me this error :

setup.js:9206 Uncaught (in promise) Error: [undefined] An unexpected error occurred when downloading file https://github.com/baal000/fvtt-chat-notifications/releases/download/v1.2.6/v1.2.6.zip: Not Found
at fetchWithTimeout (file:///home/foundry/resources/app/common/utils/http.mjs:48:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async #e (file:///home/foundry/resources/app/dist/files/downloader.mjs:1:1098)
at async file:///home/foundry/resources/app/dist/files/downloader.mjs:1:631

@baal000
Copy link
Contributor Author

baal000 commented Oct 29, 2024

Sorry for the Delay I had an error in the release Creation.
I fixed it and can now install it using https://raw.githubusercontent.com/baal000/fvtt-chat-notifications/master/module.json

@baal000 baal000 closed this Oct 29, 2024
@baal000 baal000 reopened this Oct 30, 2024
@CaosFR
Copy link

CaosFR commented Nov 1, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to v11
2 participants