Double Stream utils #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LemmaEOF
previously approved these changes
May 17, 2020
hYdos
previously approved these changes
Jan 13, 2021
|
I would expect mojang to add this officially during the 1.17 update. Mojang currently has a utility class that holds these potential additions. |
boq
approved these changes
Mar 18, 2021
slicedlime
approved these changes
Mar 18, 2021
|
I recall this implementation is a bit different from what is in the current minecraft snapshot codebase. Be cautious when migrating. |
liach
approved these changes
Mar 18, 2021
|
Thanks for checking :) |
|
We will not be taking this PR in at this time; functionality of the double stream codec should be covered with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a util in
DynamicOpsallowing for aDoubleStreamto be created from an input, and a util for a list to be created from aDoubleStream. These are direct copies of the existing variants for long and int streams.