-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argument node is not considered when literal is impermissible with same name #87
Comments
hugmanrique
added a commit
to hugmanrique/brigadier
that referenced
this issue
Apr 3, 2021
hugmanrique
added a commit
to hugmanrique/brigadier
that referenced
this issue
Apr 3, 2021
hugmanrique
added a commit
to hugmanrique/brigadier
that referenced
this issue
Apr 3, 2021
hugmanrique
added a commit
to hugmanrique/brigadier
that referenced
this issue
Apr 3, 2021
kashike
pushed a commit
to PaperMC/velocity-brigadier
that referenced
this issue
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider a literal that has two children: a literal called
bar
, and an argument node of typeStringArgumentType.word()
. The literal is impermissible, i.e. the requirement returnsfalse
, while the argument node has a non-nullCommand
. That is,Now, executing
foo bar
will fail withIncorrect argument for command at position 4: foo <--[HERE]
since the dispatcher doesn't consider the argument nodes as a fallback when the literal requirements are not met. Is this by design?Failing test
Edit: I'm working on a PR
The text was updated successfully, but these errors were encountered: