Consider arguments when literal is impermissible #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugmanrique
added a commit
to hugmanrique/Velocity
that referenced
this pull request
Apr 3, 2021
hugmanrique
added a commit
to hugmanrique/Velocity
that referenced
this pull request
Apr 3, 2021
The vanilla client doesn't know how to serialize the ArgumentTypes used by the invocation factories (see StringArrayArgumentType). ArgumentsCommandNode looks like an ArgumentCommandNode<S, String> but works like an ArgumentCommandNode<S, T>, where T is the type expected by each Command implementation. This allows for efficient parsing (just one arguments parse per execution/suggestion). PaperMC/velocity-brigadier#7 allows us to create "cheap" hinting nodes, i.e. they have a dummy #requires that returns false. Before, we needed to set the Command, requirements, suggestions... This allows for separation of concerns. The clone is still needed to set this requirement, however. PaperMC/velocity-brigadier#8 is perhaps the biggest change: we now use Brigadier redirects for command aliases. This means we no longer have to perform a deep clone of all hints and the arguments node, which can save lots of memory for hint-heavy commands and commands with lots of aliases (e.g. LuckPerms). This comes at a cost of a reference in each CommandContextBuilder and CommandContext object, which get allocated for each suggestion to test the context-aware predicate.
|
Totally forgot about this. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked.
Fixes Mojang#87