fix(debugger): Always filewatch .map and .js from sourceMapRoot, but optionally /reload minecraft. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optionally /reload minecraft.
chmeyer-ms
force-pushed
the
chmeyer/always_clear_cache
branch
from
e2c144c
to
3bf96fc
Compare
chmeyer-ms
changed the title
JakeShirley
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable file watch on
sourceMapRooteven if /reload is not enabled. This ensures the source map cache is always cleared after build.There are users (editor) that prefer manual /reload in some cases and would need to have updated source maps.
Summary:
globPatternoverride is set, enable file watch only if /reload is enabled (this feature was to watch a special pattern)sourceMapRootis set, always enable file watch for .map and .js files but don't send /reload unless enabled.From the user's perspective nothing has changed. Source maps are simply cleared more aggressively.