Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: game lobbies rounds rework #4

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat: game lobbies rounds rework #4

merged 2 commits into from
Jun 4, 2024

Conversation

Mollemoll
Copy link
Owner

Why?

API needed some refinements

What changed?

  • Lobby::new(settings) -> Lobby
  • Lobby#start_game() -> Game
  • Game#start_round() -> BidRound
  • BidRound#register_bid() -> WinningBid (This might be changed to a PlayRound or a PassRound?)

@Mollemoll Mollemoll self-assigned this Jun 4, 2024
@Mollemoll Mollemoll merged commit 7ec17e0 into main Jun 4, 2024
1 check passed
@Mollemoll Mollemoll deleted the game-lobbies-rounds-refactor branch June 4, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mollemoll Mollemoll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mollemoll