Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more granular details on vies faults #6

Merged
merged 1 commit into from
May 6, 2024

Conversation

Mollemoll
Copy link
Owner

Why?

For different reasons, government databases sometimes can't respond to whether a TaxId is verified or unverified. The VerificationStatus is set to Unavailable upon such responses.

However, more granular details should be provided to the client as some faults/errors are a result of their behaviour or should impact their behaviour. Examples would be when the client has been blocked or rate-limited.

What changed?

  • Verification is extended with a data HashMap.
  • Faults are mapped into data
  • Successful responses are mapped into data as well (details like address etc)

@Mollemoll Mollemoll self-assigned this May 6, 2024
@Mollemoll Mollemoll linked an issue May 6, 2024 that may be closed by this pull request
@Mollemoll Mollemoll merged commit 10ba4fb into main May 6, 2024
1 check passed
@Mollemoll Mollemoll deleted the 5-feat-vies-service-faults branch May 6, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: VIES service faults
1 participant