forked from matter-labs/block-explorer
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete deployment files, migrate npm to yarn & make lint pass in all packages #46
Open
tomimor
wants to merge
17
commits into
main
Choose a base branch
from
delete-deployments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 4 files 262 suites 9m 20s ⏱️ Results for commit 6c19bed. ♻️ This comment has been updated with latest results. |
API E2E Test Results207 tests 207 ✅ 18s ⏱️ Results for commit 6c19bed. ♻️ This comment has been updated with latest results. |
fix lint for worker
fix lint for app
removed non used chunk of code in app
lint fixes
lint fixes
8197a75
to
629a760
Compare
versions updated to make typecheck pass
tons of type errors fixed
fixed some tests
fixed some tests
…ble zero skipping original explorer tests that do not apply to double zero.
skip typecheck in ci.
lint fixes
try to set env variables by hand
skip 1 extra test.
aon
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Deletes all related deployment files from the project:
[x] Migrate npm to yarn
[] Make lint pass in all packages