Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(joml): migrate various pieces (no module impact) #4473

Merged
merged 12 commits into from
Feb 7, 2021

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Feb 6, 2021

Migrate various pieces of the engine code to JOML.

All these changes should be local to the engine and do not affect the Omega workspace (no module changes needed).

TeraNUI was compiled against a JOML-extension version with Rectanglei#intersects(Rectanglei) but we changed the parameter to Rectangleic - which is source compatible, not not binary compatible it seems... Checking out NUI locally works fine, so I assume just rebuilding TeraNUI against the latest SNAPSHOT of joml-ext should do the trick.

You may need to refresh your Gradle dependencies to build this:

gradlew build --refresh-dependencies

Requires a new build of MovingBlocks/TeraNUI@0b65cf1
Depends on MovingBlocks/joml-ext#20
Contributes to #3832

@skaldarnar skaldarnar added this to the v4.2.0 milestone Feb 6, 2021
@skaldarnar skaldarnar merged commit e629072 into develop Feb 7, 2021
@skaldarnar skaldarnar deleted the joml/various-migrations branch February 7, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants