Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic migration meta-server to micronauts #11

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Basic migration meta-server to micronauts #11

wants to merge 21 commits into from

Conversation

DarkWeird
Copy link
Contributor

@DarkWeird DarkWeird commented Sep 25, 2020 •
edited
Loading

Contains

  • Migrated to micronauts framework.
  • Removed Jetty and Jax-rs
  • Packages moved for common package structure.
  • Rewrited tests on micronauts.
  • Rewrite docs

Based on #10

Tests

  1. Setup local run like describe in Readme.md (gradle-way and docker-way)
  2. Try every page. should works as previos.

@DarkWeird DarkWeird changed the title Basic migrate meta-server to micronauts Basic migration meta-server to micronauts Sep 25, 2020
@DarkWeird
migration(micronauts): servlets migrated to controllers
89cdda5
@DarkWeird
migration(micronauts): fix tests
99a6d23
@DarkWeird
migration(micronauts): remove JettyMain, edit Readme.
1f2066f
@DarkWeird
migration(micronauts): remove jax-rs and jersey libs from dependencies
c6fa408
@DarkWeird
migration(micronauts): move packages to more common places.
07130d1
@DarkWeird
migration(micronauts): DI Service Renaming
dcceec0
@DarkWeird
migration(micronauts): remove retrofit. prefer micronaut's client
5d8e5df
@DarkWeird
migration(micronauts): remove data for postgres
e91071d
@DarkWeird
migration(micronauts): add test property for tests.
f67c4e0
@DarkWeird
migration(micronauts): export Module api to separate controller
cdd5d23
@DarkWeird
migration(micronauts): export Server api to separate controller
77ae6c1 
ServerController use `ModelAndView` now for Either page returns
@DarkWeird
chore(micronauts): Fix CheckStyle, Idea's and Sonar's issues
b972042
@msteiger
Copy link
Member

msteiger commented Aug 8, 2022

Just discovered this PR now 😅

If you're still around, I'd be happy to review this properly ...

@Cervator Cervator mentioned this pull request Aug 14, 2022
Merged
@DarkWeird
Copy link
Contributor Author

Just discovered this PR now 😅

If you're still around, I'd be happy to review this properly ...

Around.

Feel free ping me at discord.
Discord send pushes to me

@jdrueckert
Copy link
Member

@DarkWeird @msteiger Are you planning to revisit this?

@DarkWeird
Copy link
Contributor Author

@DarkWeird @msteiger Are you planning to revisit this?

Oh. Conflict.

Yeah.
You can ping me at any time :)

@jdrueckert
Copy link
Member

@DarkWeird This PR is really really big which makes it quite unlikely to be reviewed anytime soon... do you think you can break it down into smaller pieces?

@DarkWeird
Copy link
Contributor Author

@DarkWeird This PR is really really big which makes it quite unlikely to be reviewed anytime soon... do you think you can break it down into smaller pieces?

Hmm.
No. Iirc, It is almost minimal possible pieces.
(Except reformat)
And first step (but i am forget what to do next t-t)

Imho.
Most files easy to review - just click viewed, because it have only indent changes and moving :p

@DarkWeird
Merge remote-tracking branch 'moving/develop' into topic/micronauts
e5e2398 
# Conflicts:
#	build.gradle
#	gradle.properties
#	src/main/java/org/terasology/web/JettyMain.java
#	src/main/java/org/terasology/web/services/impl/ModuleListServiceImpl.java
#	src/test/java/org/terasology/master/WebServerBasedTests.java
@DarkWeird
refactor(micronauts): bump up micronauts version
987c6f4
@DarkWeird
Copy link
Contributor Author

@jdrueckert
conflicts resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Terasology Stabilization
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkWeird @msteiger @jdrueckert