Update external links attributes to open in a new tab #12980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Hi @ramram-mf , do you think we could address this directly at the template level? While using JS does work, it feels more like a temporary solution, and it might only apply to links available during the initial page load. Let me know your thoughts!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates all external links attributes so that these links open in a new tab.
To test
This behavior will be consistent in preview/staging apps, but not in production, since all preview/staging apps hero links point to production urls which are served from a different domain.
Link to sample test page: https://foundation-s-tp1-260-al-safchz.herokuapp.com/
Related PRs/issues: #8214
┆Issue is synchronized with this Jira Story