Show all signature matches when trying to bucket a crash. #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searching for matching buckets for an unbucketed crash only shows "good" matches, where "good" is fairly arbitrary. Instead show all matches (ordered by quality of the match), and let the user decide.
jschwartzentruber
changed the title
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 66.02% 66.01% -0.01%
==========================================
Files 80 80
Lines 7976 7975 -1
==========================================
- Hits 5266 5265 -1
Misses 2710 2710
Continue to review full report at Codecov.
|
|
@choller pointed out that this was a necessary optimization because for many signatures, searching all buckets would be unacceptably slow. needs further thought to see if both goals can be achieved. (performant and showing more matches) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for matching buckets for an unbucketed crash only shows "good" matches, where "good" is fairly arbitrary. Instead show all matches (ordered by quality of the match), and let the user decide.