chore: Update paths in rector.php and remove unnecessary comments

MrPunyapal · Aug 8, 2024 · e11af5c · e11af5c
1 parent 8608deb
commit e11af5c
Show file tree

Hide file tree

Showing 20 changed files with 41 additions and 43 deletions.
diff --git a/bootstrap/app.php b/bootstrap/app.php
@@ -14,12 +14,12 @@
         commands: __DIR__.'/../routes/console.php',
         health: '/up',
     )
-    ->withMiddleware(function (Middleware $middleware) {
+    ->withMiddleware(function (Middleware $middleware): void {
         $middleware->web(append: [
             SetLocale::class,
         ]);
 
     })
-    ->withExceptions(function (Exceptions $exceptions) {
+    ->withExceptions(function (Exceptions $exceptions): void {
         //
     })->create();
diff --git a/config/app.php b/config/app.php
@@ -103,7 +103,7 @@
 
     'previous_keys' => [
         ...array_filter(
-            explode(',', env('APP_PREVIOUS_KEYS', ''))
+            explode(',', (string) env('APP_PREVIOUS_KEYS', ''))
         ),
     ],
 

diff --git a/config/database.php b/config/database.php
@@ -57,7 +57,7 @@
             'strict' => true,
             'engine' => 'InnoDB',
             'options' => extension_loaded('pdo_mysql') ? array_filter([
-                \PDO::MYSQL_ATTR_SSL_CA => env('MYSQL_ATTR_SSL_CA'),
+                PDO::MYSQL_ATTR_SSL_CA => env('MYSQL_ATTR_SSL_CA'),
             ]) : [],
         ],
 
@@ -77,7 +77,7 @@
             'strict' => true,
             'engine' => null,
             'options' => extension_loaded('pdo_mysql') ? array_filter([
-                \PDO::MYSQL_ATTR_SSL_CA => env('MYSQL_ATTR_SSL_CA'),
+                PDO::MYSQL_ATTR_SSL_CA => env('MYSQL_ATTR_SSL_CA'),
             ]) : [],
         ],
 

diff --git a/config/logging.php b/config/logging.php
@@ -56,7 +56,7 @@
 
         'stack' => [
             'driver' => 'stack',
-            'channels' => explode(',', env('LOG_STACK', 'single')),
+            'channels' => explode(',', (string) env('LOG_STACK', 'single')),
             'ignore_exceptions' => false,
         ],
 

diff --git a/config/sanctum.php b/config/sanctum.php
@@ -20,7 +20,7 @@
     |
     */
 
-    'stateful' => explode(',', env('SANCTUM_STATEFUL_DOMAINS', sprintf(
+    'stateful' => explode(',', (string) env('SANCTUM_STATEFUL_DOMAINS', sprintf(
         '%s%s',
         'localhost,localhost:3000,127.0.0.1,127.0.0.1:8000,::1',
         Sanctum::currentApplicationUrlWithPort()

diff --git a/database/factories/CategoryFactory.php b/database/factories/CategoryFactory.php
@@ -4,10 +4,11 @@
 
 namespace Database\Factories;
 
+use App\Models\Category;
 use Illuminate\Database\Eloquent\Factories\Factory;
 
 /**
- * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\Category>
+ * @extends Factory<Category>
  */
 class CategoryFactory extends Factory
 {

diff --git a/database/factories/PostFactory.php b/database/factories/PostFactory.php
@@ -5,10 +5,11 @@
 namespace Database\Factories;
 
 use App\Enums\FeaturedStatus;
+use App\Models\Post;
 use Illuminate\Database\Eloquent\Factories\Factory;
 
 /**
- * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\Post>
+ * @extends Factory<Post>
  */
 class PostFactory extends Factory
 {

diff --git a/database/factories/UserFactory.php b/database/factories/UserFactory.php
@@ -4,16 +4,17 @@
 
 namespace Database\Factories;
 
+use App\Models\User;
 use Illuminate\Database\Eloquent\Factories\Factory;
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Str;
 
 /**
- * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\User>
+ * @extends Factory<User>
  */
 class UserFactory extends Factory
 {
-    protected static ?string $password;
+    protected static ?string $password = null;
 
     /**
      * Define the model's default state.
@@ -36,7 +37,7 @@ public function definition(): array
      */
     public function unverified(): static
     {
-        return $this->state(fn (array $attributes) => [
+        return $this->state(fn (array $attributes): array => [
             'email_verified_at' => null,
         ]);
     }

diff --git a/database/migrations/0001_01_01_000000_create_users_table.php b/database/migrations/0001_01_01_000000_create_users_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('users', function (Blueprint $table) {
+        Schema::create('users', function (Blueprint $table): void {
             $table->id();
             $table->string('name');
             $table->string('email')->unique();
@@ -23,13 +23,13 @@ public function up(): void
             $table->timestamps();
         });
 
-        Schema::create('password_reset_tokens', function (Blueprint $table) {
+        Schema::create('password_reset_tokens', function (Blueprint $table): void {
             $table->string('email')->primary();
             $table->string('token');
             $table->timestamp('created_at')->nullable();
         });
 
-        Schema::create('sessions', function (Blueprint $table) {
+        Schema::create('sessions', function (Blueprint $table): void {
             $table->string('id')->primary();
             $table->foreignId('user_id')->nullable()->index();
             $table->string('ip_address', 45)->nullable();

diff --git a/database/migrations/0001_01_01_000001_create_cache_table.php b/database/migrations/0001_01_01_000001_create_cache_table.php
@@ -13,13 +13,13 @@
      */
     public function up(): void
     {
-        Schema::create('cache', function (Blueprint $table) {
+        Schema::create('cache', function (Blueprint $table): void {
             $table->string('key')->primary();
             $table->mediumText('value');
             $table->integer('expiration');
         });
 
-        Schema::create('cache_locks', function (Blueprint $table) {
+        Schema::create('cache_locks', function (Blueprint $table): void {
             $table->string('key')->primary();
             $table->string('owner');
             $table->integer('expiration');

diff --git a/database/migrations/0001_01_01_000002_create_jobs_table.php b/database/migrations/0001_01_01_000002_create_jobs_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('jobs', function (Blueprint $table) {
+        Schema::create('jobs', function (Blueprint $table): void {
             $table->id();
             $table->string('queue')->index();
             $table->longText('payload');
@@ -23,7 +23,7 @@ public function up(): void
             $table->unsignedInteger('created_at');
         });
 
-        Schema::create('job_batches', function (Blueprint $table) {
+        Schema::create('job_batches', function (Blueprint $table): void {
             $table->string('id')->primary();
             $table->string('name');
             $table->integer('total_jobs');
@@ -36,7 +36,7 @@ public function up(): void
             $table->integer('finished_at')->nullable();
         });
 
-        Schema::create('failed_jobs', function (Blueprint $table) {
+        Schema::create('failed_jobs', function (Blueprint $table): void {
             $table->id();
             $table->string('uuid')->unique();
             $table->text('connection');

diff --git a/database/migrations/2019_12_14_000001_create_personal_access_tokens_table.php b/database/migrations/2019_12_14_000001_create_personal_access_tokens_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('personal_access_tokens', function (Blueprint $table) {
+        Schema::create('personal_access_tokens', function (Blueprint $table): void {
             $table->id();
             $table->morphs('tokenable');
             $table->string('name');

diff --git a/database/migrations/2023_12_05_085426_create_posts_table.php b/database/migrations/2023_12_05_085426_create_posts_table.php
@@ -14,7 +14,7 @@
      */
     public function up(): void
     {
-        Schema::create('posts', function (Blueprint $table) {
+        Schema::create('posts', function (Blueprint $table): void {
             $table->id();
             $table->string('title', 100);
             $table->string('slug', 120)->unique();

diff --git a/database/migrations/2023_12_05_092225_add_published_at_column_to_posts_table.php b/database/migrations/2023_12_05_092225_add_published_at_column_to_posts_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->timestamp('published_at')->nullable()->after('published');
             $table->dropColumn('published');
         });
@@ -24,7 +24,7 @@ public function up(): void
      */
     public function down(): void
     {
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->boolean('published')->default(false)->after('body');
             $table->dropColumn('published_at');
         });

diff --git a/database/migrations/2023_12_12_134541_create_categories_table.php b/database/migrations/2023_12_12_134541_create_categories_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('categories', function (Blueprint $table) {
+        Schema::create('categories', function (Blueprint $table): void {
             $table->id();
             $table->string('title', 100)->unique();
             $table->softDeletes();

diff --git a/database/migrations/2023_12_12_134928_change_category_to_category_id_in_posts_table.php b/database/migrations/2023_12_12_134928_change_category_to_category_id_in_posts_table.php
@@ -13,10 +13,10 @@
      */
     public function up(): void
     {
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->renameColumn('category', 'category_id');
         });
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->unsignedBigInteger('category_id')->change();
             $table->foreign('category_id')->references('id')->on('categories');
         });
@@ -27,10 +27,10 @@ public function up(): void
      */
     public function down(): void
     {
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->renameColumn('category_id', 'category');
         });
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->unsignedTinyInteger('category')->change();
             $table->dropForeign(['category_id']);
         });

diff --git a/database/migrations/2023_12_16_072731_rename_body_to_content_in_posts_table.php b/database/migrations/2023_12_16_072731_rename_body_to_content_in_posts_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->renameColumn('body', 'content');
         });
     }
@@ -23,7 +23,7 @@ public function up(): void
      */
     public function down(): void
     {
-        Schema::table('posts', function (Blueprint $table) {
+        Schema::table('posts', function (Blueprint $table): void {
             $table->renameColumn('content', 'body');
         });
     }

diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php
@@ -32,7 +32,7 @@ public function run(): void
 
         // Schema::enableForeignKeyConstraints();
 
-        if (Category::count() > 0) {
+        if (Category::query()->count() > 0) {
             return;
         }
 
@@ -48,7 +48,7 @@ public function run(): void
             ['title' => 'C++'],
             ['title' => 'Python'],
         )->has(
-            Post::factory()->count(rand(5, 10))
+            Post::factory()->count(random_int(5, 10))
         )->create();
     }
 }
diff --git a/pint.json b/pint.json
@@ -6,7 +6,7 @@
         "strict_comparison":true,
         "fully_qualified_strict_types": {
             "import_symbols": true,
-            "leading_backslash_in_global_namespace": true,
+            "leading_backslash_in_global_namespace": false,
             "phpdoc_tags": [
                 "phpstan-param",
                 "phpstan-property",

diff --git a/rector.php b/rector.php
@@ -9,19 +9,15 @@
 return RectorConfig::configure()
     ->withPaths([
         __DIR__.'/app',
-        // __DIR__.'/bootstrap',
-        // __DIR__.'/config',
-        // __DIR__.'/public',
-        // __DIR__.'/resources',
-        // __DIR__.'/routes',
-        // __DIR__.'/tests',
+        __DIR__.'/bootstrap/app.php',
+        __DIR__.'/config',
+        __DIR__.'/database',
+        __DIR__.'/public',
     ])
-    // register single rule
     ->withRules([
         TypedPropertyFromStrictConstructorRector::class,
     ])
     ->withPhpSets(php83: true)
-    // here we can define, what prepared sets of rules will be applied
     ->withPreparedSets(
         deadCode: true,
         codeQuality: true,
@@ -32,7 +28,6 @@
         earlyReturn: true,
         strictBooleans: true,
         carbon: true,
-        rectorPreset: true,
     )->withSets([
         LaravelSetList::LARAVEL_110,
         LaravelSetList::LARAVEL_CODE_QUALITY,