Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switch Theme Preset #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added switch Theme Preset #33

wants to merge 3 commits into from

Conversation

Tux73
Copy link

@Tux73 Tux73 commented Jan 6, 2025

  • Create a new interface IThemePreset to represent a Theme Preset.
  • Modified the MudThemeManager component to accept a collection of IThemePreset.
  • When select a Preset from UI the theme is update and the Theme manager color palette is force to update also.
  • The Theme manager color palette is update also when switch to Dark/Light theme mode.

Copy link

sonarqubecloud bot commented Jan 6, 2025

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ScarletKuro
Copy link
Member

Hi,

Thanks for the PR, I really appreciate it. However, this PR includes many unnecessary stylistic and formatting changes.

For example:

private bool _isOpen;
private bool _shouldRender;

You moved these properties from the top to after the parameters, but according to our usual convention, they should remain at the top.

There are many other unnecessary changes, such as swapping the positions of ColorPickerView and ThemeManager, as well as significant movement of items in MudThemeManager.razor.cs. Reformatting MudThemeManager.razor also makes it difficult to understand the relevant changes you made.

These kinds of stylistic refactors are only allowed by project members.

When contributing to open-source projects, please avoid making changes outside the scope of your feature. Otherwise, it will be difficult for reviewers to review and most of the time it will be rejected. I'm not trying to be difficult, it's just a standard rule in the open-source community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants