Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8 #121

Closed
wants to merge 24 commits into from
Closed

Upgrade to .NET 8 #121

wants to merge 24 commits into from

Conversation

@danielchalmers danielchalmers changed the title Upgrade to .NET 8 Upgrade to .NET 8 and update dependencies Mar 24, 2024
@danielchalmers
Copy link
Member Author

danielchalmers commented Mar 24, 2024

Current issues:

  • Have to scroll down to see page
  • __Main is either not generated or simply not showing up
  • Antiforgery preventing the ability to save snippets

Otherwise this brings the project up to date with modern Blazor practices.
Deadline is May when .NET 7 is EOL.

@Garderoben @mikes-gh When you find the time, could you look into the issues above to help me get this over the finish line? I will take another look as well after someone else has had a go. My branch is open to commits.

@mikes-gh
Copy link

@danielchalmers Sorry this diff is hard to review. I can't see anything about that relates to the issue which is the default assembly format change to wasm in net8. Perhaps you could try and reduce the diff. as a first step

@danielchalmers
Copy link
Member Author

@danielchalmers Sorry this diff is hard to review. I can't see anything about that relates to the issue which is the default assembly format change to wasm in net8. Perhaps you could try and reduce the diff. as a first step

@mikes-gh I can't really reduce it because it's so intertwined due to rebasing the project on .NET 8 default template. A lot was changed by Microsoft and it would take twice as long to split it up

@danielchalmers danielchalmers changed the title Upgrade to .NET 8 and update dependencies Upgrade to .NET 8 and rebase off new template & Update dependencies Mar 24, 2024
@danielchalmers danielchalmers changed the title Upgrade to .NET 8 and rebase off new template & Update dependencies Rebase off new Blazor template and upgrade to .NET 8 Mar 25, 2024
@danielchalmers danielchalmers marked this pull request as draft March 25, 2024 18:46
@danielchalmers danielchalmers changed the title Rebase off new Blazor template and upgrade to .NET 8 Upgrade to .NET 8 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants