Implemented optional pause/resume button in timer (#66) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request implements the functionality discussed in issue #66, adding an optional pause/resume button to the timer. The pause/resume button is discreetly integrated within the timer ring. When enabled:
When disabled, the timer behaves as usual without the button. A user setting allows enabling/disabling the pause/resume button functionality.
This functionality provides users with more control over the timer and improves the overall user experience.
The pull request includes discussions regarding the timer's behaviour after reaching the end while paused (e.g., keep elapsed time, reset to zero).
A video demonstrating the pause/resume button is attached:
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-04.at.18.05.56.mp4