Add support for consume: oneshot #109
Merged
+60
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails to build if you compile with libmpdclient 2.20 or older - mpc should be compatible with older libmpdclient releases (at least 2.18 as documented and specified in meson.build), and thus you need a compile-time check. |
|
Hey, I added version checks consistent with these old ones: 3ec5205 |
|
The second commit just fixes mistakes in the first commit - this shouldn't be a separate commit, because it is not a separate work. The second commit even re-adds code that the first code deletes, which is confusing for review. Please amend existing commits if you find mistakes instead of adding fixup commits to the same unmerged PR. |
Mstrodl
force-pushed
the
feature/mstrodl/consume-oneshot
branch
from
11d0b04
to
ae9b76d
Compare
|
I squashed the commits, let me know if you have any other feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got all the spots, but let me know if I missed anything!