Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake invoice generation #34

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Remove fake invoice generation #34

merged 1 commit into from
Apr 13, 2024

Conversation

benthecarman
Copy link
Contributor

This would cause the zap event we create to not be the same for every invoice because we would randomly generate the fake invoice. The fake invoice part of the zap recipient was mostly a gimmick, this just uses the actual invoice so we can have determinism that way the zap recipient will always be the same even if it is generated multiple times

@TonyGiorgio
Copy link
Contributor

fake invoice part of the zap recipient was mostly a gimmick

I would like to better understand why this was done at all.

@benthecarman
Copy link
Contributor Author

Slightly better privacy so we don't broadcast the gateway that was used. Doesn't really give much though because you can always just call the lightning address to get an invoice and see

@TonyGiorgio TonyGiorgio merged commit c88748f into master Apr 13, 2024
2 checks passed
@TonyGiorgio TonyGiorgio deleted the rm-fake-invoice branch April 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants