Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck for gateways if there isn't one saved #9

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

benthecarman
Copy link
Contributor

I am getting this currently: https://hermes-blinded-staging.fly.dev/lnurlp/test1234/callback?amount=10000

I assume because we don't durably save the fedimint db that we can lose the gateways we've been told about.

Finding a gateway is just lookups in the fedimint database so this shouldn't block requests.

@benthecarman
Copy link
Contributor Author

Added a gateways route to try and make debugging this easier

@TonyGiorgio
Copy link
Contributor

we don't durably save the fedimint db

We do currently, so that's not the issue.

@TonyGiorgio
Copy link
Contributor

If this is running for awhile, what stops a current gateway from going down and this doesn't switch to another one?

@benthecarman
Copy link
Contributor Author

benthecarman commented Mar 26, 2024

If this is running for awhile, what stops a current gateway from going down and this doesn't switch to another one?

yeah this is why I was talking to justin about this fedimint/fedimint#4722

Maybe should just throw out the cache and lookup every time. Originally i thought the lookup was expensive but it's not

@TonyGiorgio
Copy link
Contributor

If this is running for awhile, what stops a current gateway from going down and this doesn't switch to another one?

yeah this is why I was talking to justin about this fedimint/fedimint#4722

Maybe should just throw out the cache and lookup every time. Originally i thought the lookup was expensive but it's not

If it's a request to the federation every time then no.

@benthecarman
Copy link
Contributor Author

If it's a request to the federation every time then no.

it looks up in our local db

@TonyGiorgio
Copy link
Contributor

Then that doesn't really solve new/old gateways filtering in or out.

@benthecarman
Copy link
Contributor Author

Then that doesn't really solve new/old gateways filtering in or out.

my understanding is that these are broadcast to us and saved to our db, let me ask though

@benthecarman
Copy link
Contributor Author

Okay redid this so we periodically update our gateway db every hour and we always pick from that

@TonyGiorgio TonyGiorgio merged commit b143fea into master Mar 26, 2024
2 checks passed
@TonyGiorgio TonyGiorgio deleted the gateway-fixes branch March 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants