change input type=number in send and recieve amount #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/routes/Receive.tsx
Outdated
Comment on lines
28
to
33
| if (amount) { | ||
| const params = objectToSearchParams<ReceiveParams>({ amount, description }) | ||
| // Important! Otherwise we might see a stale bip21 code | ||
| queryClient.invalidateQueries({ queryKey: ['bip21'] }) | ||
| navigate(`/receive/qr?${params}`) | ||
| } |
There was a problem hiding this comment.
this formatting looks weird, should run the linter
This comment was marked as resolved.
This comment was marked as resolved.
|
sorry for the wave of commits, I kept thinking of more and more edge cases... |
futurepaul
approved these changes
Dec 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as referenced in MutinyWallet/mutiny-web-poc#15 the inputs for where only numbers should be are actually text currently. Hoping to prevent non-numbers and negative numbers where those would cause errors