-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change input type=number in send and recieve amount #242
Conversation
frontend/src/routes/Receive.tsx
Outdated
if (amount) { | ||
const params = objectToSearchParams<ReceiveParams>({ amount, description }) | ||
// Important! Otherwise we might see a stale bip21 code | ||
queryClient.invalidateQueries({ queryKey: ['bip21'] }) | ||
navigate(`/receive/qr?${params}`) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this formatting looks weird, should run the linter
This comment was marked as resolved.
This comment was marked as resolved.
sorry for the wave of commits, I kept thinking of more and more edge cases... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thank you! I have some followup changes so we can format this with underscores like in the ui (100_000
) but this is a great start
as referenced in MutinyWallet/mutiny-web-poc#15 the inputs for where only numbers should be are actually text currently. Hoping to prevent non-numbers and negative numbers where those would cause errors