Skip to content

Commit

Permalink
[CLEANUP] Avoid Hungarian notation in CSSBlockList (part 2) (#851)
Browse files Browse the repository at this point in the history
Part of #756
  • Loading branch information
oliverklee authored Jan 30, 2025
1 parent dbf016e commit c8a7b5f
Showing 1 changed file with 20 additions and 20 deletions.
40 changes: 20 additions & 20 deletions src/CSSList/CSSBlockList.php
Original file line number Diff line number Diff line change
Expand Up @@ -96,42 +96,42 @@ protected function allValues(
*/
protected function allSelectors(array &$result, $specificitySearch = null): void
{
/** @var array<int, DeclarationBlock> $aDeclarationBlocks */
$aDeclarationBlocks = [];
$this->allDeclarationBlocks($aDeclarationBlocks);
foreach ($aDeclarationBlocks as $oBlock) {
/** @var array<int, DeclarationBlock> $declarationBlocks */
$declarationBlocks = [];
$this->allDeclarationBlocks($declarationBlocks);
foreach ($declarationBlocks as $oBlock) {
foreach ($oBlock->getSelectors() as $selector) {
if ($specificitySearch === null) {
$result[] = $selector;
} else {
$sComparator = '===';
$aSpecificitySearch = \explode(' ', $specificitySearch);
$iTargetSpecificity = $aSpecificitySearch[0];
if (\count($aSpecificitySearch) > 1) {
$sComparator = $aSpecificitySearch[0];
$iTargetSpecificity = $aSpecificitySearch[1];
$comparator = '===';
$expressionParts = \explode(' ', $specificitySearch);
$targetSpecificity = $expressionParts[0];
if (\count($expressionParts) > 1) {
$comparator = $expressionParts[0];
$targetSpecificity = $expressionParts[1];
}
$iTargetSpecificity = (int) $iTargetSpecificity;
$iSelectorSpecificity = $selector->getSpecificity();
$bMatches = false;
switch ($sComparator) {
$targetSpecificity = (int) $targetSpecificity;
$selectorSpecificity = $selector->getSpecificity();
$comparatorMatched = false;
switch ($comparator) {
case '<=':
$bMatches = $iSelectorSpecificity <= $iTargetSpecificity;
$comparatorMatched = $selectorSpecificity <= $targetSpecificity;
break;
case '<':
$bMatches = $iSelectorSpecificity < $iTargetSpecificity;
$comparatorMatched = $selectorSpecificity < $targetSpecificity;
break;
case '>=':
$bMatches = $iSelectorSpecificity >= $iTargetSpecificity;
$comparatorMatched = $selectorSpecificity >= $targetSpecificity;
break;
case '>':
$bMatches = $iSelectorSpecificity > $iTargetSpecificity;
$comparatorMatched = $selectorSpecificity > $targetSpecificity;
break;
default:
$bMatches = $iSelectorSpecificity === $iTargetSpecificity;
$comparatorMatched = $selectorSpecificity === $targetSpecificity;
break;
}
if ($bMatches) {
if ($comparatorMatched) {
$result[] = $selector;
}
}
Expand Down

0 comments on commit c8a7b5f

Please sign in to comment.