Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Avoid Hungarian notation for oRule/oRuleSet #835

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[CLEANUP] Avoid Hungarian notation for oRule/oRuleSet #835

merged 1 commit into from
Jan 27, 2025

Conversation

oliverklee
Copy link
Contributor

Part of #756

@oliverklee oliverklee self-assigned this Jan 27, 2025
@coveralls
Copy link

coveralls commented Jan 27, 2025 •
edited
Loading

Coverage Status

coverage: 44.039%. remained the same
when pulling b06f903 on cleanup/hungarian-orule
into 1d76088 on main.

@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 27, 2025

Will need a rebase...

@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 27, 2025

Note this change also does the same for $oRuleSet.

@oliverklee
Copy link
Contributor Author

Note this change also does the same for $oRuleSet.

Indeed - good catch! I've updated the PR title and commit message accordingly.

@oliverklee oliverklee changed the title [CLEANUP] Avoid Hungarian notation for oRule [CLEANUP] Avoid Hungarian notation for oRule/oRuleSet Jan 27, 2025
@oliverklee oliverklee force-pushed the cleanup/hungarian-orule branch from 3657ed1 to b06f903 Compare January 27, 2025 22:51
@oliverklee oliverklee requested a review from JakeQZ January 27, 2025 22:51
@JakeQZ JakeQZ merged commit d5374c5 into main Jan 27, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian-orule branch January 27, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ