-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avatar-group): Avatar group component #707
Conversation
321gillian
commented
Nov 15, 2024
- Simplified version with dedicated group item avatar implementation.
- Using menu pattern as per - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role
- Keyboard nav based off of the menu example: https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3049_v4 |
@321gillian What is the intended function of a click or enter on one of the circles? I've noticed that clicking on any of the circles seems to send the exact same data ( |
I'm still seeing the same thing.. maybe the new demo didn't publish yet? I can show you what I mean if that would help |
Having an issue with the build in Jenkins. Will revert once I fix it. |
...onents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.scss
Outdated
Show resolved
Hide resolved
...onents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.scss
Show resolved
Hide resolved
...onents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.scss
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
packages/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.tsx
Show resolved
Hide resolved
packages/genesys-spark-components/src/components/beta/gux-avatar-group/readme.md
Outdated
Show resolved
Hide resolved
9e13ddd
to
d0dae85
Compare
cac6e9b
to
b79df1f
Compare
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Outdated
Show resolved
Hide resolved
packages/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.tsx
Show resolved
Hide resolved
packages/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.tsx
Outdated
Show resolved
Hide resolved
packages/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.tsx
Show resolved
Hide resolved
850dbbc
to
103859b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hitting "enter" to click is causing a console error. Clicking with mouse does not
103859b
to
a0eae53
Compare
a0eae53
to
cbad4fd
Compare
cbad4fd
to
282def2
Compare