Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatar-group): Avatar group component #707

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

321gillian
Copy link
Collaborator

@321gillian 321gillian self-assigned this Nov 15, 2024
Copy link

@jordanstith15
Copy link
Collaborator

@321gillian What is the intended function of a click or enter on one of the circles?

I've noticed that clicking on any of the circles seems to send the exact same data (detail is always 1) and hitting enter when focused doesn't have the same data as a click (missing detail) according to the doc notification

@jordanstith15
Copy link
Collaborator

@321gillian What is the intended function of a click or enter on one of the circles?

I've noticed that clicking on any of the circles seems to send the exact same data (detail is always 1) and hitting enter when focused doesn't have the same data as a click (missing detail) according to the doc notification

I'm still seeing the same thing.. maybe the new demo didn't publish yet? I can show you what I mean if that would help

@321gillian
Copy link
Collaborator Author

@321gillian What is the intended function of a click or enter on one of the circles?
I've noticed that clicking on any of the circles seems to send the exact same data (detail is always 1) and hitting enter when focused doesn't have the same data as a click (missing detail) according to the doc notification

I'm still seeing the same thing.. maybe the new demo didn't publish yet? I can show you what I mean if that would help

Having an issue with the build in Jenkins. Will revert once I fix it.

@gavin-everett-genesys
Copy link
Collaborator

Overall looks good to me 👍

Some small issue found when manually testing,

  1. If I keyboard focus on an avatar and it shows the tooltip and I mouse click on another avatar the keyboard focussed avatar does not get deselected and the tooltip continues showing,

Screenshot 2024-11-18 at 10 52 07

@321gillian 321gillian force-pushed the feature/COMUI-3049_v4 branch from 9e13ddd to d0dae85 Compare November 18, 2024 15:20
@321gillian
Copy link
Collaborator Author

Overall looks good to me 👍

Some small issue found when manually testing,

  1. If I keyboard focus on an avatar and it shows the tooltip and I mouse click on another avatar the keyboard focussed avatar does not get deselected and the tooltip continues showing,

Screenshot 2024-11-18 at 10 52 07

updated to fix this

@321gillian 321gillian force-pushed the feature/COMUI-3049_v4 branch 2 times, most recently from cac6e9b to b79df1f Compare November 21, 2024 12:57
@321gillian 321gillian force-pushed the feature/COMUI-3049_v4 branch 8 times, most recently from 850dbbc to 103859b Compare November 21, 2024 16:43
Copy link
Collaborator

@jordanstith15 jordanstith15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hitting "enter" to click is causing a console error. Clicking with mouse does not

@321gillian 321gillian force-pushed the feature/COMUI-3049_v4 branch from cbad4fd to 282def2 Compare November 25, 2024 17:00
@321gillian 321gillian merged commit 762f92f into main Nov 25, 2024
3 checks passed
@321gillian 321gillian deleted the feature/COMUI-3049_v4 branch November 25, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants