feat(avatar-groups): Add overflow #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3050-overflow |
github-actions
bot
requested review from
gavin-everett-genesys and
jason-evans-genesys
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
2 times, most recently
from
2b77284 to
c291214
Compare
321gillian
commented
Dec 23, 2024
| visual-only | ||
| placement="top" | ||
| ref={el => (this.tooltip = el)} | ||
| <Host role="menuitem"> |
There was a problem hiding this comment.
This role needs to be in the light dom, otherwise the menu won't announce the number of items in the menu
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
from
da7952d to
5b99fa4
Compare
321gillian
changed the title
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
2 times, most recently
from
fadc06d to
60dce21
Compare
...es/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.service.ts
Outdated
Show resolved
Hide resolved
packages/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.tsx
Outdated
Show resolved
Hide resolved
.../gux-avatar-group/gux-avatar-overflow/gux-avatar-overflow-item/gux-avatar-overflow-item.scss
Show resolved
Hide resolved
...ents/src/components/beta/gux-avatar-group/gux-avatar-overflow/gux-avatar-overflow.service.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+116
to
+115
| resetFocusableSibling(clickedElement); | ||
| setFocusTarget(clickedElement); | ||
| } |
There was a problem hiding this comment.
I was just wondering what is the intended response when you click a gux-avatar-group-item-beta is the focus moved somewhere ?
There was a problem hiding this comment.
There's a convention in menus and avatar groups that I've seen where the last item visited by keyboard or clicked is set at the current focus target. So if you tab back up from below then you return to the last item clicked / the one you tabbed away from.
packages/genesys-spark-components/src/components/beta/gux-avatar-group/gux-avatar-group.tsx
Outdated
Show resolved
Hide resolved
...a/gux-avatar-group/gux-avatar-overflow/gux-avatar-overflow-item/gux-avatar-overflow-item.tsx
Show resolved
Hide resolved
...a/gux-avatar-group/gux-avatar-overflow/gux-avatar-overflow-item/gux-avatar-overflow-item.tsx
Outdated
Show resolved
Hide resolved
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
2 times, most recently
from
e5fc0cf to
46fce8c
Compare
321gillian
requested review from
jason-evans-genesys and
gavin-everett-genesys
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
from
46fce8c to
3ccd099
Compare
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
from
3ccd099 to
0422877
Compare
321gillian
commented
Jan 21, 2025
...ponents/src/components/beta/gux-avatar-group/gux-avatar-group-item/gux-avatar-group-item.tsx
Show resolved
Hide resolved
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
from
0422877 to
840967e
Compare
...components/src/components/beta/gux-avatar-group/gux-avatar-overflow/gux-avatar-overflow.scss
Outdated
Show resolved
Hide resolved
| @Prop() | ||
| quantity: GuxAvatarGroupQuantity = Math.max( | ||
| ...GROUP_QUANTITIES | ||
| ) as GuxAvatarGroupQuantity; |
There was a problem hiding this comment.
So we are purposely limiting the max quantity to the max of the number array? Is that why it's done this way?
There was a problem hiding this comment.
I checked this with Monse and we don't need to limit it to a max so I've updated it to remove the restriction.
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
from
840967e to
0cdf1c1
Compare
321gillian
force-pushed
the
feature/COMUI-3050-overflow
branch
from
6709011 to
3f03442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's enough in this as it is so I've added another follow-on task for the next part: https://inindca.atlassian.net/browse/COMUI-3367