Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a sync button in the preview panel #1236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Myriad-Dreamin
Copy link
Owner

When a client doesn't implement the bidirectional jumping feature (lsp notifications), a sync button is used as a fallback solution. This is useful, because a client, like helix and zed, usually cannot handle these bidirectional jump notifications.

The sync button works in this way:

  • when user triggers a hover and completion, the server remembers it.
  • when user presses the sync button, the server request to jump a document location in preview corresponding to the source location held in the last step.
  • the preview panel can optionally render the source location for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant