Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formatter] Next batch of improvements #20414

Merged
merged 9 commits into from
Nov 26, 2024
Merged

[formatter] Next batch of improvements #20414

merged 9 commits into from
Nov 26, 2024

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Nov 25, 2024

Description

Preparing features for v0.2.0 release:

  • abilities are now sorted in key, copy, drop, store order
  • if no longer creates a block if expression is not block and breaks
  • empty structs now support comments
  • empty blocks now support comments
  • packages prettier-move binary which simplifies CLI setup
  • renames prettier parser name from move-parser to move

TODOs

  • migrate to new Move tree-sitter version
  • add more tests for empty block scenarios in breaking and non-breaking versions
  • ...

Test plan

Features tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@damirka damirka self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 6:50pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 6:50pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 6:50pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 6:50pm

@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs November 26, 2024 13:14 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit November 26, 2024 13:14 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk November 26, 2024 13:14 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 13:14 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 13:16 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs November 26, 2024 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk November 26, 2024 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit November 26, 2024 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit November 26, 2024 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk November 26, 2024 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs November 26, 2024 13:19 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 13:19 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit November 26, 2024 13:22 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk November 26, 2024 13:22 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 13:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs November 26, 2024 13:22 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit November 26, 2024 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk November 26, 2024 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs November 26, 2024 17:06 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 17:06 — with GitHub Actions Inactive
@damirka damirka requested a review from amnn November 26, 2024 17:06
@damirka damirka marked this pull request as ready for review November 26, 2024 17:06
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 17:06 — with GitHub Actions Inactive
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a ton of context on the formatting changes but prettier-move and README changes look good!

@vercel vercel bot temporarily deployed to Preview – multisig-toolkit November 26, 2024 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs November 26, 2024 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk November 26, 2024 17:33 Inactive
@damirka damirka had a problem deploying to sui-typescript-aws-kms-test-env November 26, 2024 17:33 — with GitHub Actions Failure
- abilities are now sorted in `key`, `copy`, `drop`, `store` order
- if no longer creates a block if expression is not block and breaks
- empty structs now support comments
- empty blocks now support comments
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 18:49 — with GitHub Actions Inactive
@damirka damirka merged commit 53387ff into main Nov 26, 2024
51 of 52 checks passed
@damirka damirka deleted the ds/prettier-update branch November 26, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants