Move `TxContext` implementation via natives and sponsor #21245

dariorussi · 2025-02-16T20:40:36Z

Description

This enables Move TxContext to use native functions. It also expose a fun sponsor(self: &TxContext): Option<address> that returns the address of the sponsor if the transaction was sponsored.

tx_context.rs has all the changes to allow gas_price, gas_budget and sponsor.
I moved TransactionContext (the struct pushed to NativeContextExtension) in its own directory like crypto and object_runtime. In time TransactionContext may evolve to have a richer API so it made sense to have it in its own directory.

Test plan

Sponsor test coming

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

vercel · 2025-02-16T20:40:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 5, 2025 3:19pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview		Mar 5, 2025 3:19pm
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview		Mar 5, 2025 3:19pm

awelc · 2025-02-25T23:30:57Z

crates/sui-protocol-config/src/lib.rs

@@ -3254,7 +3283,19 @@ impl ProtocolConfig {
                        cfg.feature_flags.passkey_auth = true;
                    }
                }
-                76 => {}
+                76 => {
+                    cfg.feature_flags.move_native_context = false;


Why value 30?

see answer to @tnowacki 's same comment

awelc · 2025-02-25T23:40:02Z

sui-execution/latest/sui-move-natives/src/lib.rs

@@ -338,11 +355,77 @@ impl NativesCostTable {
                    .transfer_share_object_cost_base()
                    .into(),
            },
+            // tx_context


Not sure about the meaning of this comment (is it cut short?)

I can remove it but it was to highlight that the API below is for the tx_context and other part of this code do the same, so it was to replicate what is there already and to mark where that API is

tzakian · 2025-02-25T23:42:45Z

crates/sui-types/src/base_types.rs

-    pub fn fresh_id(&mut self) -> ObjectID {
-        let id = ObjectID::derive_id(self.digest(), self.ids_created);
+    pub fn sender(&self) -> SuiAddress {
+        SuiAddress::from(ObjectID(self.sender))


I would recommend self.sender.into() or possibly SuiAddress:from(self.sender) here. Going through ObjectID to get there feels just wasteful lol

tzakian · 2025-02-25T23:46:48Z

crates/sui-protocol-config/src/lib.rs

+                76 => {
+                    cfg.feature_flags.move_native_context = false;
+
+                    cfg.tx_context_fresh_id_cost_base = Some(30);


This should be the same as tx_context_derive_id_cost_base. You could even reuse that one instead of this one possibly if you wanted to?

fair, I will put that value in here for now, good point.
Later we will tune if we need to.
I did not want to reuse that value because I am not sure how those functions will evolve.
The derived_id may disappear, not sure

tnowacki · 2025-02-26T00:08:27Z

sui-execution/latest/sui-move-natives/src/tx_context.rs

+ * native fun fresh_id
+ * Implementation of the Move native function `fun fresh_id(): address`
+ **************************************************************************************************/
+pub fn fresh_id(


Wait, what even is this function? Is it fresh_object_address? Why isn't that kept in Move?

see comment about that above (as an asnwer to @tzakian) we need to compute the fresh id in the new model and that is all in rust.
How could we do that in Move code?

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 16, 2025 20:40 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 16, 2025 20:41 View deployment

dariorussi force-pushed the dario/native_impl branch from bd777b4 to 18f21c9 Compare February 17, 2025 16:26

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 17, 2025 16:27 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 17, 2025 16:28 View deployment

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 17, 2025 18:09 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 17, 2025 18:10 View deployment

dariorussi force-pushed the dario/native_impl branch from df2b8dd to b04724e Compare February 18, 2025 19:45

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 18, 2025 19:45 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 18, 2025 19:46 View deployment

dariorussi force-pushed the dario/native_impl branch from b04724e to 9953050 Compare February 19, 2025 16:39

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 19, 2025 16:40 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 19, 2025 16:41 View deployment

vercel bot deployed to Preview – sui-docs February 19, 2025 17:43 View deployment

dariorussi force-pushed the dario/native_impl branch from f7a8d94 to 6e915c8 Compare February 19, 2025 23:35

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 19, 2025 23:35 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 19, 2025 23:37 View deployment

dariorussi force-pushed the dario/native_impl branch from 6e915c8 to 2cc1767 Compare February 21, 2025 15:57

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 21, 2025 15:57 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 21, 2025 16:01 View deployment

dariorussi force-pushed the dario/native_impl branch from 2cc1767 to a9ceb02 Compare February 21, 2025 18:35

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 21, 2025 18:35 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 21, 2025 18:36 View deployment

dariorussi force-pushed the dario/native_impl branch from a9ceb02 to 0c0dd72 Compare February 22, 2025 14:21

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 22, 2025 14:21 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 22, 2025 14:22 View deployment

dariorussi force-pushed the dario/native_impl branch from 0c0dd72 to fa43f35 Compare February 23, 2025 17:10

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 23, 2025 17:10 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 23, 2025 17:12 View deployment

awelc reviewed Feb 25, 2025

View reviewed changes

tzakian reviewed Feb 25, 2025

View reviewed changes

tnowacki reviewed Feb 26, 2025

View reviewed changes

vercel bot deployed to Preview – sui-docs February 26, 2025 05:18 View deployment

dariorussi force-pushed the dario/native_impl branch from bde973a to d1212cd Compare February 27, 2025 03:16

dariorussi requested a review from ronny-mysten as a code owner February 27, 2025 03:16

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 27, 2025 03:16 — with GitHub Actions Inactive

dariorussi changed the title ~~Rust TxContext changes and Move native functions implementation~~ Move TxContext implementation via natives and sponsor Feb 27, 2025

vercel bot deployed to Preview – sui-docs February 27, 2025 03:18 View deployment

dariorussi force-pushed the dario/native_impl branch from d1212cd to 1450da3 Compare February 27, 2025 04:05

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 27, 2025 04:05 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs February 27, 2025 04:06 View deployment

dariorussi force-pushed the dario/native_impl branch from 1450da3 to c64140e Compare February 28, 2025 05:39

vercel bot deployed to Preview – sui-docs February 28, 2025 05:41 View deployment

dariorussi force-pushed the dario/native_impl branch from c64140e to 100114f Compare February 28, 2025 15:51

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 15:51 — with GitHub Actions Inactive

dariorussi force-pushed the dario/native_impl branch from 100114f to f77bf7a Compare March 1, 2025 13:13

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env March 1, 2025 13:13 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs March 1, 2025 13:19 View deployment

dariorussi force-pushed the dario/native_impl branch from f77bf7a to cd14ea6 Compare March 1, 2025 20:54

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env March 1, 2025 20:54 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs March 1, 2025 20:56 View deployment

dariorussi force-pushed the dario/native_impl branch from cd14ea6 to 5bb2321 Compare March 1, 2025 22:23

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env March 1, 2025 22:23 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs March 1, 2025 22:25 View deployment

dariorussi added 2 commits March 5, 2025 07:25

Move TxContext native and sponsor

e9409d8

snapshots

c14b731

dariorussi force-pushed the dario/native_impl branch from 5bb2321 to c14b731 Compare March 5, 2025 15:17

dariorussi temporarily deployed to sui-typescript-aws-kms-test-env March 5, 2025 15:17 — with GitHub Actions Inactive

vercel bot deployed to Preview – sui-docs March 5, 2025 15:19 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move `TxContext` implementation via natives and sponsor #21245

Move `TxContext` implementation via natives and sponsor #21245

dariorussi commented Feb 16, 2025 •

edited

Loading

vercel bot commented Feb 16, 2025 •

edited

Loading

awelc Feb 25, 2025

dariorussi Feb 26, 2025

awelc Feb 25, 2025

dariorussi Feb 26, 2025

tzakian Feb 25, 2025

tzakian Feb 25, 2025

dariorussi Feb 26, 2025 •

edited

Loading

tnowacki Feb 26, 2025

dariorussi Feb 26, 2025

Move TxContext implementation via natives and sponsor #21245

Are you sure you want to change the base?

Move TxContext implementation via natives and sponsor #21245

Conversation

dariorussi commented Feb 16, 2025 • edited Loading

Description

Test plan

Release notes

vercel bot commented Feb 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dariorussi Feb 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Move `TxContext` implementation via natives and sponsor #21245

Move `TxContext` implementation via natives and sponsor #21245

dariorussi commented Feb 16, 2025 •

edited

Loading

vercel bot commented Feb 16, 2025 •

edited

Loading

dariorussi Feb 26, 2025 •

edited

Loading