[TrafficControl] Scale spam sample weight by request size #21373
+57
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
force-pushed
the
william/scale-weight-by-request-size
branch
from
fa4df00 to
10b720e
Compare
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
force-pushed
the
william/scale-weight-by-request-size
branch
from
10b720e to
3e8eba1
Compare
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
reviewed
Mar 4, 2025
| async move { | ||
| if let Some(traffic_controller) = traffic_controller { | ||
| let client = req.extensions().get::<IpAddr>().cloned(); | ||
| if let Err(response) = handle_traffic_req(&traffic_controller, &client).await { | ||
| response | ||
| } else { | ||
| // Scale the weight based on the request size | ||
| let spam_weight = if policy_config.unwrap().weight_spam_by_request_size { | ||
| println!("TESTING -- weighting spam by request size"); |
There was a problem hiding this comment.
don't want to merge this i assume
| let params_count = req.params.as_ref().and_then(|p| { | ||
| let raw_value = p.get(); | ||
| let params: Option<Vec<serde_json::Value>> = | ||
| serde_json::from_str(raw_value).ok(); |
There was a problem hiding this comment.
this won't handle nested params, right? I no it is a bit more fragile and has a lot of boilerplate but i wonder if the request handler needs to explicitly determine a param count?
| ) { | ||
| println!("TESTING -- spam_weight: {:?}", spam_weight); |
|
oh sorry i didn't notice this was a draft. ignore my comments for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.