Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public doc for passkeys for testnet launch #21374

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

abhinavg6
Copy link
Contributor

Description

Adding a public doc for passkeys for testnet launch. It's a high-level doc that links to the relevant to the TS SDK doc and the SIP.

Test plan

@joyqvq has done the relevant dev testing, and beyond that we've tested the feature in devnet using a sample app and a community-built app.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@abhinavg6 abhinavg6 marked this pull request as ready for review February 27, 2025 20:40
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 9:03pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 9:03pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 9:03pm

@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Feb 27, 2025
@abhinavg6 abhinavg6 temporarily deployed to sui-typescript-aws-kms-test-env February 27, 2025 20:41 — with GitHub Actions Inactive
@abhinavg6 abhinavg6 temporarily deployed to sui-typescript-aws-kms-test-env February 27, 2025 20:41 — with GitHub Actions Inactive
@abhinavg6
Copy link
Contributor Author

cc @joyqvq @ronny-mysten for review - thank you


Go to [zkLogin](./cryptography/zklogin.mdx).

## Passkeys

Passkeys is a Sui primitive that enables you to sign-in to apps and send transactions to Sui using a private key securely stored on a authenticator. It uses the WebAuthn standard.
Copy link
Contributor

@joyqvq joyqvq Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Passkeys is a Sui primitive that enables you to sign-in to apps and send transactions to Sui using a private key securely stored on a authenticator. It uses the WebAuthn standard.
Sui supports passkey signature scheme that enables you to sign-in to apps and sign transactions to Sui using a private key securely stored on a passkey authenticator. It uses the WebAuthn standard.


Passkeys provide a secure and user-friendly alternative for submitting transactions to Sui. Built on the **WebAuthn standard**, passkeys let users authenticate and sign transactions using:

- Hardware security keys, such as YubiKeys)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Hardware security keys, such as YubiKeys)
- Hardware security keys, such as YubiKeys


Passkeys simplify authentication by removing the need to manage seed phrases or private keys manually. Instead, they rely on device-based authentication and cloud synchronization, allowing seamless, phishing-resistant access across multiple devices.

By integrating passkeys, Sui improves security and accessibility, making it easier for users to manage their accounts without compromising decentralization or cryptographic security.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By integrating passkeys, Sui improves security and accessibility, making it easier for users to manage their accounts without compromising decentralization or cryptographic security.
By supporting passkey signature scheme, Sui improves security and accessibility, making it easier for users to manage their accounts with hardened security. Passkey wallets are also tied to the origin, meaning they can’t be phished or used on a different site, which makes it a safer user wallet option.


By integrating passkeys, Sui improves security and accessibility, making it easier for users to manage their accounts without compromising decentralization or cryptographic security.

Refer to [Typescript SDK support](https://sdk.mystenlabs.com/typescript/cryptography/passkey) on how to add passkey support to your application. Also feel free to refer to [SIP-9](https://github.com/sui-foundation/sips/blob/main/sips/sip-9.md) for product specification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: standardize the passkey usage, referring to it as passkey instead of passkeys (to be consistent with code)


Users can sign transactions directly on devices with built-in authenticators (such as Face ID on iPhones or Windows Hello on Windows PCs). This approach lets users sign transactions natively without needing an external security key.

**Recover access and secure accounts with multi-signature authentication**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cloud synchronization has nothing to do with multisig, just mention the passkey is recoverable if synced in cloud is sufficient.


Users cannot transfer passkeys between different authenticators. For example, a passkey created on a security key cannot move to another device unless it syncs through a cloud provider. To avoid losing access, users should set up authentication on multiple devices.

**Multisig support is not available yet**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can mark this as available in testnet or remove mentioning this

@joyqvq
Copy link
Contributor

joyqvq commented Feb 27, 2025

lgtm with inlined comments addressed

@abhinavg6
Copy link
Contributor Author

Thanks @joyqvq - addressed all the feedback

@ronny-mysten - Can I request you to please review and merge by Monday? This would be deployed to testnet with Tuesday release. Thanks.

@ronny-mysten ronny-mysten temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 20:52 — with GitHub Actions Inactive
@ronny-mysten ronny-mysten temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 20:52 — with GitHub Actions Inactive
@ronny-mysten ronny-mysten enabled auto-merge (squash) February 28, 2025 20:53
@ronny-mysten ronny-mysten merged commit dd00db5 into MystenLabs:main Feb 28, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants