Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formatter] bugs & fixes #21381

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[formatter] bugs & fixes #21381

wants to merge 5 commits into from

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Feb 28, 2025

Description

  • dot_expression now supports trailing comment in a list
  • a single element of an arg_list can have trailing line comment
  • a single element of an arg_list can have leading line comment

Test plan

Features tests for all the cases.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

- dot_expression now supports traliing comment in a list
- arg_list of a single element can have trailing line comment
- arg_list of a single element can have leading line comment
@damirka damirka requested a review from awelc February 28, 2025 11:34
@damirka damirka self-assigned this Feb 28, 2025
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 1:11pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Skipped (Inspect) Mar 3, 2025 1:11pm
sui-kiosk ⬜️ Skipped (Inspect) Mar 3, 2025 1:11pm

@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 11:22 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 11:22 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 3, 2025 11:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 12:28 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 3, 2025 12:29 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 13:06 Inactive
@damirka damirka had a problem deploying to sui-typescript-aws-kms-test-env March 3, 2025 13:06 — with GitHub Actions Failure
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 13:09 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 13:09 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 3, 2025 13:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant