[kv store] add metrics #21385
Open
[kv store] add metrics #21385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
bigtable_metrics
branch
from
3da464e to
ae088d5
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
bigtable_metrics
branch
from
ae088d5 to
acfe7a7
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
bigtable_metrics
branch
from
acfe7a7 to
988e223
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
bigtable_metrics
branch
from
988e223 to
bdc12d6
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
emmazzz
reviewed
Feb 28, 2025
emmazzz
reviewed
Feb 28, 2025
| let num_keys_requested = keys.len(); | ||
| let result = self.multi_get_internal(table_name, keys).await; | ||
| let labels = [&self.client_name, table_name]; | ||
| match &self.metrics { |
There was a problem hiding this comment.
I think having metrics in multi_get labeled by table is very useful. But I wonder if it would be useful to all group by method because we have multiple methods that may hit the same table, like get_latest_object and get_objects and it would be useful to know if their metrics are somehow different.
There was a problem hiding this comment.
This PR only covers multi_get, and there is only one method per column family.
reversed_scan can be added as followup.
Just curious, why the indexer needs to rely on the KV store for get_latest_object call?
phoenix-o
force-pushed
the
bigtable_metrics
branch
from
bdc12d6 to
09053bb
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
bigtable_metrics
branch
from
09053bb to
dcd0f4e
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bigtable get metrics
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.