Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[json-rpc] Update variants to be returned in declaration order" #21413

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Revert "[json-rpc] Update variants to be returned in declaration order" #21413

merged 1 commit into from
Mar 4, 2025
+7 −18

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Mar 4, 2025

Reverts #21359

The change in the format is causing breaking issues for clients. Revert back to previous layout for now.

@tzakian tzakian requested review from mlegner and bmwill March 4, 2025 21:08
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:09pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 9:09pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 9:09pm

@tzakian tzakian temporarily deployed to sui-typescript-aws-kms-test-env March 4, 2025 21:08 — with GitHub Actions Inactive
@tzakian tzakian enabled auto-merge (squash) March 4, 2025 21:09
mlegner
mlegner approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have enough context to tell if that affects anything else.

@tzakian tzakian disabled auto-merge March 4, 2025 21:12
@tzakian tzakian merged commit 1b99d41 into main Mar 4, 2025
47 checks passed
@tzakian tzakian deleted the revert-21359-tzakian/decl-order-variants-json-rpc branch March 4, 2025 22:06
tzakian added a commit that referenced this pull request Mar 4, 2025
@tzakian
Revert "[json-rpc] Update variants to be returned in declaration orde…
ba82e5d 
…r" (#21413)

Reverts #21359

The change in the format is causing breaking issues for clients. Revert
back to previous layout for now.
tzakian added a commit that referenced this pull request Mar 4, 2025
@tzakian
Revert "[json-rpc] Update variants to be returned in declaration orde…
556b6e1 
…r" (#21413) (#21414)

Reverts #21359

The change in the format is causing breaking issues for clients. Revert
back to previous layout for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

@bmwill bmwill Awaiting requested review from bmwill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzakian @mlegner