Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-pip as build dependency #36

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

rcrdnalor
Copy link
Contributor

Commit MythTV/mythtv@8ece26b added python3-pip as build dependency (in configure) for modern Linux variants.

Updated specs for Ubuntu >= 23.04, Debian 12 and Fedora 39+.

  • MythTV master for Ubuntu 23.04 is already build with python3-pip on Launchpad.
  • Debian 12 has a recent version of python3-pip.
  • Fedora 39, once released has python3.12 which requires python3-pip for building.

Note: For Debian and its derivatives, the package python3-pip depends on python3-wheel.

Completely untested.

Commit MythTV/mythtv@8ece26b
added python3-pip as build dependency (in configure) for
modern Linux variants.

Updated specs for Ubuntu >= 23.04, Debian 12 and Fedora 39+.

 - MythTV master for Ubuntu 23.04 is already build with python3-pip
   on Launchpad.
 - Debian 12 has a recent version of python3-pip.
 - Fedora 39, once released has python3.12 which requires
   python3-pip for building.

Note: For Debian and its derivates, the package python3-pip
depends on python3-wheel.
@rcrdnalor rcrdnalor requested a review from billmeek September 21, 2023 19:01
@rcrdnalor
Copy link
Contributor Author

@billmeek : Could you please review it ?

@billmeek
Copy link
Contributor

Will do when I get back. Probably next week.

@kmdewaal
Copy link
Contributor

Updating ansible with PR36 and then executing gives this:

klaas@kasus:~/git/ansible$ ./mythtv.yml --limit=localhost
[DEPRECATION WARNING]: [defaults]collections_paths option, does not fit var naming standard, use the singular form collections_path instead. This feature will be removed from ansible-core in version 2.19. Deprecation warnings
 can be disabled by setting deprecation_warnings=False in ansible.cfg.

@kmdewaal
Copy link
Contributor

Hi Roland, from your comment on issue #848

On Ubuntu, you need only install the python3-pip package.
On Fedora 39, you need to install the python3-wheel package as well.

Tested this also yesterday on Fedora 39 but I the python3-wheel was not installed by ansible.
Does it still need to be added or did I miss something?

rcrdnalor and others added 2 commits January 26, 2024 18:35
There is no strict dependency from 'pip' to the 'wheel'
package on Fedora.

Refs MythTV#36
@billmeek billmeek merged commit 0e8d6c0 into MythTV:master Jan 26, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants