-
Notifications
You must be signed in to change notification settings - Fork 345
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add avprogram_id to streams_changed() callback
This is an int to match type with AVProgram. In mpegts.c, SectionHeader::id is a uint16_t as ISO/IEC 13818-1:2021 specifies for program_number. This allows us to ignore stream changes in programs that are not being watched when there is more than one program. Regarding the changes to mpeg.c: Originally from: dvb/ac3 patches 1, 2, and 3 from Mark Anderson 87795f6 changed in: Refs #8134. internal dvd player. resolve problem where pcm_s16be audi… e64371a change reverted in: Refs #8134. revert most of [24239]. Anduin withers reported it makes … a3d6e14 referencing: #8134 (internal dvd player: pcm_s16be improperly detected as pcm_dvd audio codec.) – MythTV https://code.mythtv.org/trac/ticket/8134 An MPEG Program Stream can only have one program, so FFmpeg does not create an AVProgram for it. Thus av_find_program_from_stream() (and therefore get_current_AVProgram()) will always return nullptr, so avprogram_id will be ignored. The calling conventions of functions with "C" and "C++" language linkage are not necessarily the same; however, in practice they are, so AvFormatDecoder::streams_changed() could be used directly. Doing it correctly still eliminates the use of a friend function and its double declaration at only the cost of an extra function call, which doesn't matter since streams_changed() is only called very rarely.
- Loading branch information
1 parent
f0625bd
commit 4ce4353
Showing
5 changed files
with
21 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters