configure cleanup #1010
Open
configure cleanup #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were from FFmpeg, but unused by MythTV.
They already were, but make it clearer.
Removed duplicate test for non-zero length optflags, since it was already checked if zero length.
Added with optimization flags
copies ffmpeg_optenable but removes the else branch
I think these have been unused since MythGallery was removed: fce4029
Neither cabs() nor cexp() are used.
Only used in FFmpeg.
Functions used in MythTV: access closesocket eglGetProcAddress fcntl fork getaddrinfo gettimeofday gmtime_r inet_aton isatty jack_port_get_latency_range LoadLibrary localtime_r lstat mkstemp mmap nanosleep PeekNamedPipe sysconf sysctl usleep wl_surface_set_opaque_region Not checked for: libexiv2: MapViewOfFile Sleep libbluray: strerror_r gettimeofday libdvdnav: setmode ffnvcodec: LoadLibrary Only used are: HAVE_GETMNTENT_R in libmythbluray HAVE_GETTIMEOFDAY in libdvdnav, libdvdread, libmythbase/logging.cpp and libmythbase/loggingserver.cpp libexiv2 has its own EXV_HAVE_GMTIME_R EXV_HAVE_STRERROR_R EXV_HAVE_MMAP EXV_HAVE_LSTAT When removing closesocket, also remove unused HAVE_STRUCT_*, including CONDITION_VARIABLE_Ptr, socklen_t, struct_rusage_ru_maxrss, and struct_stat_st_mtim_tv_nsec kCMVideoCodecType_HEVC is FFmpeg only.
This is only defined when building FFmpeg, otherwise it should not be defined and does not need to be `undef`ed.
libexiv2 has its own EXV_HAVE_SYS_MMAN_H and EXV_HAVE_UNISTD_H Switch NuppelVideoRecorder.cpp to __has_include(). Remove never defined HAVE_CONFIG_H in lirc_client.cpp. MALLOC_PREFIX is only used in FFmpeg
ulmus-scott
force-pushed
the
configure2
branch
from
75879b9 to
3029b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most of the remaining commits from #430
This speeds up configure slightly:
24.303s baseline
24.171s COMPLEX_FUNCS
22.502s MATH_FUNCS
20.717s trim SYSTEM_FUNCS and TYPES_LIST
20.498s trim HEADERS_LIST
About 9.5 seconds from FFmpeg's configure.
Checklist