metadata/Music: remove unused external dependency on simplejson #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simplejson module was added to the python standard library in 2.6; here, it is inconsistently imported for python 2.6 (where it already exists) and lower (where it does not) instead of using `json`. But, mythtv only supports python 3.8 for a while now. So this conditional is merely dead code. The import name is still aliased using `as simplejson`, though, which is bad for visibility and analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplejson module was added to the python standard library in 2.6; here, it is inconsistently imported for python 2.6 (where it already exists) and lower (where it does not) instead of using
json.But, mythtv only supports python 3.8 for a while now. So this conditional is merely dead code. The import name is still aliased using
as simplejson, though, which is bad for visibility and analysis.Part of #824