Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale factor to LWP obs to convert to g m-2. #283

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

nusbaume
Copy link
Collaborator

@nusbaume nusbaume commented Feb 8, 2024

Adds an obs scale factor to the TGCLDLWP variable to ensure that both the model and the observations are in units of g m-2.

Credit goes to @bstephens82 for finding and reporting the bug!

@nusbaume nusbaume added the bug-fix Fixes a particular bug (or set of bugs) label Feb 8, 2024
@nusbaume nusbaume self-assigned this Feb 8, 2024
@bstephens82
Copy link
Contributor

Thanks @nusbaume for creating this PR. Just wanted to add the same change should probably be applied to TGCLDIWP as it has the same problem.

@nusbaume
Copy link
Collaborator Author

nusbaume commented Feb 8, 2024

@bstephens82 Good catch! The scale factor has now been added to TGCLDIWP as well.

Copy link
Collaborator

@justin-richling justin-richling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the additional plot details @bstephens82!

@nusbaume nusbaume merged commit 50c6e65 into NCAR:main Feb 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Fixes a particular bug (or set of bugs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants