Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize create_climo_files.py #355

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

brianpm
Copy link
Collaborator

@brianpm brianpm commented Jan 30, 2025

This changes create_climo_files.py to use adf.data.get_ref_timeseries_file and adf.data.get_timeseries_file to locate the names of the time series files.

This removes the option to provide a custom search string for the time series files, but this could be added to adf.data if needed.

The advantage of this approach is that it means that create_climo_files.py doesn't have to deal with particular history file strings. In cases where the user has supplied a list of history files in the YAML file, the time series generation will loop through the history files, and then create_climo_files.py just finds those time series files. This does mean that if the user provides history file streams that contain the same variable there will be some kind of conflict.

This PR is a step toward being able to include COSP variables back into ADF because currently they have to be written on the CAM native grid (and therefore usually in a separate history stream).

@justin-richling justin-richling merged commit 0f94593 into NCAR:main Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants