Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
create_climo_files.py
to useadf.data.get_ref_timeseries_file
andadf.data.get_timeseries_file
to locate the names of the time series files.This removes the option to provide a custom search string for the time series files, but this could be added to
adf.data
if needed.The advantage of this approach is that it means that
create_climo_files.py
doesn't have to deal with particular history file strings. In cases where the user has supplied a list of history files in the YAML file, the time series generation will loop through the history files, and thencreate_climo_files.py
just finds those time series files. This does mean that if the user provides history file streams that contain the same variable there will be some kind of conflict.This PR is a step toward being able to include COSP variables back into ADF because currently they have to be written on the CAM native grid (and therefore usually in a separate history stream).