Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tasklist_completed.yml #110

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Conversation

TeaganKing
Copy link
Collaborator

@TeaganKing TeaganKing commented Jun 26, 2024

Add workflow to ensure that task lists are completed before merging pull requests.

  • Test if this works?

@TeaganKing
Copy link
Collaborator Author

TeaganKing commented Jun 26, 2024

  • looks like this requires some permission changes, which I want to look into carefully.

@TeaganKing TeaganKing self-assigned this Jun 26, 2024
@TeaganKing
Copy link
Collaborator Author

TeaganKing commented Jul 3, 2024

These seem like the main two options, but neither seems to work exactly as expected. If comments are added, the task checker is not necessarily re-run, and the 'kentaro' version doesn't seem to display a check near the 'merge pull request' section. Maybe I'm doing this incorrectly, though.

https://github.com/marketplace/actions/github-pr-tasklist-checker
https://github.com/marketplace/actions/task-completed-checker

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I hope moving the PR template makes it work :)

@TeaganKing TeaganKing merged commit 151aeb9 into NCAR:main Jul 3, 2024
1 check passed
@TeaganKing TeaganKing deleted the tasklist-checker branch July 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants